linux-kernel - Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8bbc1a5-f00e-c257-9119-f5e91bd68b59@molgen.mpg.de>
Date:   Mon, 14 Nov 2016 18:35:17 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     David Miller <davem@...emloft.net>
Cc:     bhe@...hat.com, netdev@...r.kernel.org, michael.chan@...adcom.com,
        linux-kernel@...r.kernel.org, Dept-GELinuxNICDev@...ium.com,
        rasesh.mody@...ium.com, harish.patil@...ium.com,
        frank@...ermydesk.org, jsr@....edzone.net, jroedel@...e.de,
        dyoung@...hat.com
Subject: Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe
 stage

On 11/14/16 18:28, David Miller wrote:
> From: Paul Menzel <pmenzel@...gen.mpg.de>
> Date: Mon, 14 Nov 2016 09:25:47 +0100

>> On 11/13/16 06:01, Baoquan He wrote:
>>> This is v2 post.
>>>
>>> In commit 3e1be7a ("bnx2: Reset device during driver initialization"),
>>> firmware requesting code was moved from open stage to probe stage.
>>> The reason is in kdump kernel hardware iommu need device be reset in
>>> driver probe stage, otherwise those in-flight DMA from 1st kernel
>>> will continue going and look up into the newly created io-page tables.
>>> However bnx2 chip resetting involves firmware requesting issue, that
>>> need be done in open stage.
>>>
>>> Michale Chan suggested we can just wait for the old in-flight DMA to
>>> complete at probe stage, then though without device resetting, we
>>> don't need to worry the old in-flight DMA could continue looking up
>>> the newly created io-page tables.
>>>
>>> v1->v2:
>>>     Michael suggested to wait for the in-flight DMA to complete at probe
>>>     stage. So give up the old method of trying to reset chip at probe
>>>     stage, take the new way accordingly.
>>
>> thank you for posting the updated series. Could you please resend a v3
>> with stable@...r.kernel.org added [1]?
>
> This is not the proper procedure for networking patches.

Oh, I didn’t know that. Sorry for spreading false information.


Kind regards,

Paul