linux-kernel - Re: [PATCH] mfd: sun4i-gpadc: select regmap-irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161114174010.GA4094@dell>
Date:   Mon, 14 Nov 2016 17:40:10 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Quentin Schulz <quentin.schulz@...e-electrons.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: sun4i-gpadc: select regmap-irq

On Mon, 31 Oct 2016, Arnd Bergmann wrote:

> The new sun4i mfd driver is lacking a dependency, triggering very rarely
> int randconfig kernel builds:
> 
> drivers/mfd/sun4i-gpadc.o: In function `sun4i_gpadc_probe':
> sun4i-gpadc.c:(.text.sun4i_gpadc_probe+0x110): undefined reference to `devm_regmap_add_irq_chip'
> 
> This adds a 'select REGMAP_IRQ', as the other drivers with this problem do.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 30978295a1e8..3a4c43df9404 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -44,6 +44,7 @@ config MFD_SUN4I_GPADC
>  	tristate "Allwinner sunxi platforms' GPADC MFD driver"
>  	select MFD_CORE
>  	select REGMAP_MMIO
> +	select REGMAP_IRQ
>  	depends on ARCH_SUNXI || COMPILE_TEST
>  	help
>  	  Select this to get support for Allwinner SoCs (A10, A13 and A31) ADC.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog