linux-kernel - Re: [PATCH] mfd: bcm590xx: Simplify a test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161114174046.GB4094@dell>
Date:   Mon, 14 Nov 2016 17:40:46 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mfd: bcm590xx: Simplify a test

On Tue, 01 Nov 2016, Christophe JAILLET wrote:

> 'i2c_new_dummy()' does not return an error pointer, so the test can be
> simplified to be more consistent.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/mfd/bcm590xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
> index 0d76d690176b..c572a35a9341 100644
> --- a/drivers/mfd/bcm590xx.c
> +++ b/drivers/mfd/bcm590xx.c
> @@ -67,7 +67,7 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri,
>  	/* Secondary I2C slave address is the base address with A(2) asserted */
>  	bcm590xx->i2c_sec = i2c_new_dummy(i2c_pri->adapter,
>  					  i2c_pri->addr | BIT(2));
> -	if (IS_ERR_OR_NULL(bcm590xx->i2c_sec)) {
> +	if (!bcm590xx->i2c_sec) {
>  		dev_err(&i2c_pri->dev, "failed to add secondary I2C device\n");
>  		return -ENODEV;
>  	}

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog