linux-kernel - Re: [PATCH 2/2] sched/autogroup: a zombie thread must not use autogroup->tg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161114185817.GA15995@redhat.com>
Date:   Mon, 14 Nov 2016 19:58:17 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Ingo Molnar <mingo@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Mike Galbraith <efault@....de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:     hartsjc@...hat.com, vbendel@...hat.com, vlovejoy@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] sched/autogroup: a zombie thread must not use
 autogroup->tg

On 11/14, Oleg Nesterov wrote:
>
> +void sched_autogroup_exit_task(struct task_struct *p)
> +{
> +	/*
> +	 * We are going to call exit_notify() and autogroup_move_group() can't
> +	 * see this thread after that: we can no longer use signal->autogroup.
> +	 * See the PF_EXITING check in task_wants_autogroup().
> +	 */
> +	sched_move_task(p);

We only need it if task_group_is_autogroup(task_group(p)) but then this code
will need even more comments, lets keep it simple.

Oleg.