linux-kernel - FireWire/ nosy compile error (was gregkh@...uxfoundation.org linux-kernel@...r.kernel.org)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2016 21:51:53 +0100
From:   Stefan Richter <stefanr@...6.in-berlin.de>
To:     Karatas Ozgur <mueddib@...nldap.org>
Cc:     linux-kernel@...r.kernel.org, linux1394-devel@...ts.sourceforge.net
Subject: FireWire/ nosy compile error (was gregkh@...uxfoundation.org 
 linux-kernel@...r.kernel.org)

On Nov 14 Karatas Ozgur wrote:
> Hi,
> 
> I fixed compile error, not include to FIREWIRE variable and only PCI return an error.
> 
> 
> diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
> 
> index 145974f..60e5a8c 100644
> --- a/drivers/firewire/Kconfig
> +++ b/drivers/firewire/Kconfig
> @@ -57,7 +57,7 @@ config FIREWIRE_NET
> 
> config FIREWIRE_NOSY
>         tristate "Nosy - a FireWire traffic sniffer for PCILynx cards"
> -       depends on PCI
> +       depends on FIREWIRE && PCI
>         help
>           Nosy is an IEEE 1394 packet sniffer that is used for protocol
>           analysis and in development of IEEE 1394 drivers, applications,

This is wrong.  The variable FIREWIRE enables the firewire-core driver.
But nosy is a stand-alone driver which does not depend on firewire-core.

Please tell us what your compile error was (and on what platform), so that
we can find out which dependency was really missing, if any.
-- 
Stefan Richter
-======----- =-== -===-
http://arcgraph.de/sr/