linux-kernel - [PATCH] arm64: dts: rockchip: add gmac needed clk for rk3399 pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1479098199-20170-1-git-send-email-wxt@rock-chips.com>
Date:   Mon, 14 Nov 2016 12:36:39 +0800
From:   Caesar Wang <wxt@...k-chips.com>
To:     heiko@...ech.de
Cc:     dianders@...omium.org, linux-arm-kernel@...ts.infradead.org,
        zhangqing@...k-chips.com, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Jeffy Chen <jeffy.chen@...k-chips.com>,
        Caesar Wang <wxt@...k-chips.com>
Subject: [PATCH] arm64: dts: rockchip: add gmac needed clk for rk3399 pd

From: Jeffy Chen <jeffy.chen@...k-chips.com>

This patch fixes that sometimes hang at start-up time of the system.
As the below log:
...
[   11.136543] calling  pm_genpd_debug_init+0x0/0x60 @ 1
[   11.141602] initcall pm_genpd_debug_init+0x0/0x60 returned 0 after 11 usecs
[   11.148558] calling  genpd_poweroff_unused+0x0/0x84 @ 1
<hang>

In some cases, the rk3399 should turn off the gmac power domain to save
power if some boards didn't register the gmac device node for rk3399.
Then, rk3399 need to make sure the gmac's pclk enabled if we need
operate the gmac power domain. (Due to the NOC had enabled always)

Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
Signed-off-by: Caesar Wang <wxt@...k-chips.com>
---

 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 172e7ed..e8b9df9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -825,7 +825,8 @@
 			/* These power domains are grouped by VD_LOGIC */
 			pd_gmac@...399_PD_GMAC {
 				reg = <RK3399_PD_GMAC>;
-				clocks = <&cru ACLK_GMAC>;
+				clocks = <&cru ACLK_GMAC>,
+					 <&cru PCLK_GMAC>;
 				pm_qos = <&qos_gmac>;
 			};
 			pd_vio@...399_PD_VIO {
-- 
2.7.4