linux-kernel - RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB5PR0401MB1925E0CF1B6C9780A0E5DE60F5BC0@DB5PR0401MB1925.eurprd04.prod.outlook.com>
Date:   Mon, 14 Nov 2016 04:46:35 +0000
From:   Sriram Dash <sriram.dash@....com>
To:     Peter Chen <hzpeterchen@...il.com>, Arnd Bergmann <arnd@...db.de>
CC:     Felipe Balbi <felipe.balbi@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Suresh Gupta <suresh.gupta@....com>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "pku.leo@...il.com" <pku.leo@...il.com>
Subject: RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

>From: Peter Chen [mailto:hzpeterchen@...il.com]
>On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote:
>> On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
>> > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)  void
>> > > dwc3_host_exit(struct dwc3 *dwc)  {
>> > >       phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
>> > > -                       dev_name(&dwc->xhci->dev));
>> > > +                       dev_name(dwc->dev));
>> > >       phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy",
>> > > -                       dev_name(&dwc->xhci->dev));
>> > > +                       dev_name(dwc->dev));
>> >
>> > this looks unrelated to $subject. Care to explain?
>>
>> bus->sysdev is used for retrieving any information that comes from
>> the platform (DT or otherwise), and the phy lookup in has to be done
>> through sysdev as well because the platform cannot add it to the child
>> device it has no knowledge of.
>>
>> When we set the sysdev to the parent, the phy lookup has to be added
>> to that device as well, rather than the child device.
>>
>
>Then, the device should change to dwc->sysdev, and phy_create_lookup in this file
>needs to change too.
>

Yes Peter. I agree to that. 

>--
>
>Best Regards,
>Peter Chen