linux-kernel - Re: [PATCH RESEND] drm/ast: free correct pointer in astfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161114064602.gag5lrwlrrbmqebw@phenom.ffwll.local>
Date:   Mon, 14 Nov 2016 07:46:03 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Andrew Donnellan <andrew.donnellan@....ibm.com>
Cc:     airlied@...il.com, dri-devel@...ts.freedesktop.org,
        daniel.vetter@...ll.ch, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create()
 error paths

On Mon, Nov 14, 2016 at 02:03:59PM +1100, Andrew Donnellan wrote:
> In the err_free_vram and err_release_fbi error paths in astfb_create(), we
> attempt to free afbdev->sysram. The only jumps to these error paths occur
> before we assign afbdev->sysram = sysram. Free sysram instead.
> 
> Signed-off-by: Andrew Donnellan <andrew.donnellan@....ibm.com>

Applied to drm-misc, thanks.
-Daniel

> 
> ---
> 
> Found by Coverity Scan. Compile tested only.
> ---
>  drivers/gpu/drm/ast/ast_fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 7a86e24..d6f5ec6 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -253,7 +253,7 @@ static int astfb_create(struct drm_fb_helper *helper,
>  err_release_fbi:
>  	drm_fb_helper_release_fbi(helper);
>  err_free_vram:
> -	vfree(afbdev->sysram);
> +	vfree(sysram);
>  	return ret;
>  }
>  
> -- 
> Andrew Donnellan              OzLabs, ADL Canberra
> andrew.donnellan@....ibm.com  IBM Australia Limited
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch