linux-kernel - RE: [patch v3 1/1] platform/x86: move module mlx-platform from arch/x86 to drivers/platform/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2016 08:10:09 +0000
From:   Vadim Pasternak <vadimp@...lanox.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>
Subject: RE: [patch v3 1/1] platform/x86: move module mlx-platform from
 arch/x86 to drivers/platform/x86



> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Monday, November 14, 2016 9:17 AM
> To: Vadim Pasternak <vadimp@...lanox.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>; dvhart@...radead.org; platform-
> driver-x86@...r.kernel.org; x86@...nel.org; linux-kernel@...r.kernel.org;
> jiri@...nulli.us; andriy.shevchenko@...ux.intel.com
> Subject: Re: [patch v3 1/1] platform/x86: move module mlx-platform from
> arch/x86 to drivers/platform/x86
> 
> On Tue, Nov 8, 2016 at 8:19 AM, Vadim Pasternak <vadimp@...lanox.com>
> wrote:
> > Hi,
> >
> > Could this patch be merged to for-next for 4.10?
> > When it's merged I'd like to submit another small patch on top of it.
> 

Hi Andy,
Thanks for reply.

> First of all, please avoid top posting.

Sorry for that.
I posted on top, because it doesn't come as reply to something (but it seems I should post at bottom in suc case).

> I will process the pdx86 mailing list and queue this week.
> 
> P.S. Are you sure that is the right fix "Remove "select MLX_PLATFORM"
> from Kconfig, since it has unmet direct dependencies (X86 &&
> X86_PLATFORM_DEVICES && X86_64)"?

There were two possibility: to leave "select MLX_PLATFORM" and add " depends on X86_64". Or just remove select.
I decide to remove, having in mind the next considerations:
If MLX_PLATFORM is not selected here - just nobody will activate hotplug driver;
If in the feature on some systems we'll have ACPI support - hotplug still is relevant. 

> 
> >> On Mon, 31 Oct 2016, Vadim Pasternak wrote:
> >>
> >> > Since mlx-platform is not an architectural driver, it is moved out
> >> > of arch/x86/platform to drivers/platform/x86.
> >> > Relevant Makefile and Kconfig are updated.
> >> >
> >> > Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> >>
> >> Acked-by: Thomas Gleixner <tglx@...utronix.de>
> 
> --
> With Best Regards,
> Andy Shevchenko