linux-kernel - Re: [PATCH] irqdomain: fix compiling when IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe24eced-750c-abc6-b0bc-9bbda6e52e21@arm.com>
Date:   Mon, 14 Nov 2016 10:41:08 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Stefan Christ <contact@...fanchrist.eu>, alexander.deucher@....com,
        christian.koenig@....com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqdomain: fix compiling when IRQ_DOMAIN unset

Hi Stephan,

On 13/11/16 15:59, Stefan Christ wrote:
> When config option IRQ_DOMAIN is unset, compiling the file
> 'drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c' fails:
> 
>       CC      drivers/gpu/drm/amd/amdgpu/amdgpu_irq.o
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c: In function ‘amdgpu_irq_dispatch’:
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:345:3: error: implicit declaration of
>         function ‘irq_find_mapping’ [-Werror=implicit-function-declaration]
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c: In function ‘amdgpu_irq_add_domain’:
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:529:2: error: implicit declaration of
>         function ‘irq_domain_add_linear’ [-Werror=implicit-function-declaration]
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c: In function ‘amdgpu_irq_remove_domain’:
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:550:3: error: implicit declaration of
>         function ‘irq_domain_remove’ [-Werror=implicit-function-declaration]
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c: In function ‘amdgpu_irq_create_mapping’:
>     drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:569:2: error: implicit declaration of
>         function ‘irq_create_mapping’ [-Werror=implicit-function-declaration]
> 
> Adding the functions stubs in the header file so it compiles cleanly.
> Maybe the drm driver 'amdgpu' should select the config option IRQ_DOMAIN
> if it cannot work without it. But I don't know if that's necessary.

This looks like the wrong fix to me, as you just end-up with a
non-functional driver which will compiles just fine, making it even
harder to find out what's wrong with it.

Selecting IRQ_DOMAIN is a much saner option.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...