linux-kernel - Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fumu2uuv.fsf@intel.com>
Date:   Mon, 14 Nov 2016 12:56:08 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Fabian Frederick <fabf@...net.be>, Ben Skeggs <bskeggs@...hat.com>
Cc:     fabf@...net.be, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

On Sat, 12 Nov 2016, Fabian Frederick <fabf@...net.be> wrote:
> -#if defined(CONFIG_HWMON) || (defined(MODULE) && defined(CONFIG_HWMON_MODULE))
> +#if IS_REACHABLE(CONFIG_HWMON)

The changes seem to make sense per se, but I'd be interested in hearing
the rationale for not expressing this dependency in terms of Kconfig to
begin with. With this, it's hidden in code, and the hwmon stuff gets
used if the conditions for "nouveau depends on hwmon" are met, by
chance, but it's not enforced.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center