linux-kernel - Re: [PATCH v3 0/2] arm64: Support systems without FP/ASIMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161114110819.GA3096@e104818-lin.cambridge.arm.com>
Date:   Mon, 14 Nov 2016 11:08:19 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     Suzuki K Poulose <suzuki.poulose@....com>, mark.rutland@....com,
        ard.biesheuvel@...aro.org, will.deacon@....com,
        linux-kernel@...r.kernel.org, kvmarm@...ts.cs.columbia.edu,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 0/2] arm64: Support systems without FP/ASIMD

On Fri, Nov 11, 2016 at 01:41:37PM +0000, Marc Zyngier wrote:
> On 08/11/16 13:56, Suzuki K Poulose wrote:
> > This series adds supports to the kernel and KVM hyp to handle
> > systems without FP/ASIMD properly. At the moment the kernel
> > doesn't check if the FP unit is available before accessing
> > the registers (e.g during context switch). Also for KVM,
> > we trap the FP/ASIMD accesses and handle it by injecting an
> > undefined instruction into the VM on systems without FP.
> > 
> > Tested on a FVP_Base-AEM-v8A model by disabling VFP on at
> > least one CPU ( -C clusterX.cpuY.vfp-present=0 ).
> > 
> > Changes since V2:
> >  - Dropped cleanup patch for arm64/crypto/aes-ce-ccm-glue.c
> >  - Removed static_key check from cpus_have_cap. All users with
> >    constant caps should use the new API to make use of static_keys.
> >  - Removed a dedicated static_key used in irqchip-gic-v3.c for
> >    Cavium errata with the new API.
> > 
> > Applies on v4.9-rc4 + [1] (which is pushed for rc5)
> > 
> > [1] http://marc.info/?l=linux-arm-kernel&m=147819889813214&w=2
> > 
> > 
> > Suzuki K Poulose (2):
> >   arm64: Add hypervisor safe helper for checking constant capabilities
> >   arm64: Support systems without FP/ASIMD
> > 
> >  arch/arm64/include/asm/cpucaps.h    |  3 ++-
> >  arch/arm64/include/asm/cpufeature.h | 24 +++++++++++++++++-------
> >  arch/arm64/include/asm/neon.h       |  3 ++-
> >  arch/arm64/kernel/cpufeature.c      | 17 ++++++++++++++++-
> >  arch/arm64/kernel/fpsimd.c          | 14 ++++++++++++++
> >  arch/arm64/kernel/process.c         |  2 +-
> >  arch/arm64/kvm/handle_exit.c        | 11 +++++++++++
> >  arch/arm64/kvm/hyp/hyp-entry.S      |  9 ++++++++-
> >  arch/arm64/kvm/hyp/switch.c         |  5 ++++-
> >  drivers/irqchip/irq-gic-v3.c        | 13 +------------
> >  10 files changed, 76 insertions(+), 25 deletions(-)
> 
> For the series:
> 
> Reviewed-by: Marc Zyngier <marc.zyngier@....com>
> 
> How do we plan on merging this? Catalin, are you willing to take it all?

Happy to take it all through the arm64 tree. Thanks for the review.

-- 
Catalin