linux-kernel - [RFC][PATCH 0/2] fsnotify: reduce coupling of permission and non permission events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1479124107-8477-1-git-send-email-amir73il@gmail.com>
Date:   Mon, 14 Nov 2016 13:48:25 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Jan Kara <jack@...e.cz>
Cc:     Jeff Layton <jlayton@...chiereds.net>,
        Miklos Szeredi <miklos@...redi.hu>,
        Eric Paris <eparis@...hat.com>, Eryu Guan <eguan@...hat.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: [RFC][PATCH 0/2] fsnotify: reduce coupling of permission and non permission events

The issue reported by Miklos Szeredi was processes blocking when trying
to close an inotify file descriptor, while another fanotify listener is
failing to handle permission events.

Miklos included a test program with the report.
His test program with some modifications is available on my github:
https://github.com/amir73il/fsnotify-utils/blob/master/fanotify_bug.c

Ideally, we would want that destruction of a group would only block
if an event handled by this group is in progress, but this is not easy
to achieve. Instead, we make sure that destrurction of a group would
only block if an event handled by a group of similar class (priority)
is in progress.

Amir Goldstein (2):
  fsnotify: separate fsnotify_mark_srcu for groups with permission
    events
  fsnotify: handle permission events without holding
    fsnotify_mark_srcu[0]

 fs/notify/fanotify/fanotify.c | 15 ++++++---
 fs/notify/fsnotify.c          | 57 ++++++++++++++++++++++++++++----
 fs/notify/fsnotify.h          | 17 ++++++++--
 fs/notify/group.c             |  2 +-
 fs/notify/mark.c              | 77 ++++++++++++++++++++++++++++++++-----------
 5 files changed, 134 insertions(+), 34 deletions(-)

-- 
2.7.4