linux-kernel - Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161114135521.GA10151@gmail.com>
Date:   Mon, 14 Nov 2016 14:55:22 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Matt Fleming <matt@...eblueprint.co.uk>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed
 the UEFI RNG table


* Matt Fleming <matt@...eblueprint.co.uk> wrote:

> On Sun, 13 Nov, at 08:19:39AM, Ingo Molnar wrote:
> > 
> > * Matt Fleming <matt@...eblueprint.co.uk> wrote:
> > 
> > > From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > > 
> > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and
> > > install the Linux-specific RNG seed UEFI config table. This will be
> > > picked up by the EFI routines in the core kernel to seed the kernel
> > > entropy pool.
> > > 
> > > Cc: Matt Fleming <matt@...eblueprint.co.uk>
> > > Reviewed-by: Kees Cook <keescook@...omium.org>
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > 
> > This commit (and the commits after this one) doesn't have a proper signoff chain, 
> > probably due to rebasing?
>  
> Argh, my bad. This is fallout from moving to the co-maintainer model.
> My scripts assume they don't need to append a SoB because that was
> handled when applying the patch to the git tree.
> 
> But that obviously doesn't hold if Ard applies the patch to git, but I
> mail out the patches as part of the pull request (or vice versa).
> 
> I guess in future you'd wanna see the SoB of the person mailing the
> patches, right?

The problem is not that Ard applied the patches, but that you subsequently rebased 
the tree. For example:

 commit bf5d1f98c1d8be04a40eabb9dd6913347b1b3fc4
 Author:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
 AuthorDate: Thu Oct 20 12:21:26 2016 +0100
 Commit:     Matt Fleming <matt@...eblueprint.co.uk>
 CommitDate: Sat Nov 12 21:14:41 2016 +0000

    efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table
    
    Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and
    install the Linux-specific RNG seed UEFI config table. This will be
    picked up by the EFI routines in the core kernel to seed the kernel
    entropy pool.
    
    Cc: Matt Fleming <matt@...eblueprint.co.uk>
    Reviewed-by: Kees Cook <keescook@...omium.org>
    Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

if you rebase it (with your co-maintainer's permission) then you need to add your 
SoB tag.

Thanks,

	Ingo