linux-kernel - [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2016 09:30:03 +0100
From:   Shiva Kerdel <shiva@...ev.nl>
To:     stuart.yoder@....com
Cc:     gregkh@...uxfoundation.org, German.Rivera@...escale.com,
        treding@...dia.com, itai.katz@....com,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        Shiva Kerdel <shiva@...ev.nl>
Subject: [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16'

After following a discussion about the used integer types Dan Carpenter
pointed out that 'int' types should be used over the current change to
's16'. The reason for this is to have an upper bound instead of overflowing
the 's16' so we could still remove devices.

Signed-off-by: Shiva Kerdel <shiva@...ev.nl>
Suggested-by: Stuart Yoder <stuart.yoder@....com>
Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
---
 drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
index c7cad87..42700de 100644
--- a/drivers/staging/fsl-mc/include/mc-bus.h
+++ b/drivers/staging/fsl-mc/include/mc-bus.h
@@ -42,8 +42,8 @@ struct msi_domain_info;
  */
 struct fsl_mc_resource_pool {
 	enum fsl_mc_pool_type type;
-	s16 max_count;
-	s16 free_count;
+	int max_count;
+	int free_count;
 	struct mutex mutex;	/* serializes access to free_list */
 	struct list_head free_list;
 	struct fsl_mc_bus *mc_bus;
-- 
2.10.2