linux-kernel - Re: [PATCH] audit: tame initialization warning len_abuf in audit_log_execve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161115085120.GJ27818@madcap2.tricolour.ca>
Date:   Tue, 15 Nov 2016 03:51:20 -0500
From:   Richard Guy Briggs <rgb@...hat.com>
To:     Paul Moore <paul@...l-moore.com>
Cc:     linux-audit@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: tame initialization warning len_abuf in
 audit_log_execve_info

On 2016-11-14 15:21, Paul Moore wrote:
> On Thu, Nov 10, 2016 at 1:39 AM, Richard Guy Briggs <rgb@...hat.com> wrote:
> > Tame initialization warning of len_abuf in audit_log_execve_info even
> > though there isn't presently a bug introduced by commit 43761473c254
> > ("audit: fix a double fetch in audit_log_single_execve_arg()").  Using
> > UNINITIALIZED_VAR instead may mask future bugs.
> >
> > Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> > ---
> >  kernel/auditsc.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Compiler warnings are annoying, regardless of if they are actually
> problems or not so I'm going to merge this ... although I'm pretty
> sure in a year or two somebody is going to submit a one-liner removing
> this because it's unnecessary :)

Unnecessary on some versions of some compilers...

> > diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> > index e414dfa..d161b17 100644
> > --- a/kernel/auditsc.c
> > +++ b/kernel/auditsc.c
> > @@ -1000,7 +1000,7 @@ static void audit_log_execve_info(struct audit_context *context,
> >         long len_rem;
> >         long len_full;
> >         long len_buf;
> > -       long len_abuf;
> > +       long len_abuf = 0;
> >         long len_tmp;
> >         bool require_data;
> >         bool encode;

- RGB

--
Richard Guy Briggs <rgb@...hat.com>
Kernel Security Engineering, Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635