linux-kernel - Re: [PATCH] pinctrl: vt8500: make bool drivers explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbr+TcyLZrX6ZFs+xYOb4MOcGLJ7UKeESuWE7EmATUiOQ@mail.gmail.com>
Date:   Tue, 15 Nov 2016 10:04:55 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Tony Prisk <linux@...sktech.co.nz>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: vt8500: make bool drivers explicitly non-modular

On Wed, Nov 9, 2016 at 4:45 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> None of the Kconfigs for any of these drivers are tristate, meaning
> that they currently are not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the drivers there is no doubt they are builtin-only.  All
> drivers get the exact same change, so they are handled in batch.
>
> Changes are (1) use builtin_platform_driver, (2) use init.h header
> (3) delete module_exit related code, (4) delete MODULE_DEVICE_TABLE,
> (5) delete MODULE_LICENCE/MODULE_AUTHOR and associated tags and (6)
> drop ".remove" code and prevent sysfs unbind attempts to call ".remove".
>
> Once this is done, the shared remove function in wmt.[ch] is no longer
> used and hence it is removed as well.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE etc. tags since all that information
> is already contained at the top of each file in the comments.
>
> Cc: Tony Prisk <linux@...sktech.co.nz>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Patch applied.

Yours,
Linus Walleij