linux-kernel - Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal string length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64c4a261-1097-6baa-0ab0-b9ca16bcdf66@bingham.xyz>
Date:   Tue, 15 Nov 2016 09:49:15 +0000
From:   Kieran Bingham <kieran@...uared.org.uk>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Javier Martinez Canillas <javier@....samsung.com>,
        sameo@...ux.intel.com
Subject: Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal
 string length



On 14/11/16 22:27, Wolfram Sang wrote:
> On Mon, Nov 07, 2016 at 12:47:43PM +0000, Kieran Bingham wrote:
>> If a user provides a shortened string to match a device to the sysfs i2c
>> interface it will match on the first string that contains that string
>> prefix.
>>
>> for example:
>>   echo a 0x68 > /sys/bus/i2c/devices/i2c-2/new_device
>> will match as3711, as3722, and ak8975 incorrectly.
>>
>> Correct this by using sysfs_streq to match the string exactly
>>
>> Signed-off-by: Kieran Bingham <kieran@...gham.xyz>
> 
> Any objections that I squash this directly into patch 2? It is more like
> a bugfix, no?

No objection

Acked-by: Kieran Bingham <kieran@...gham.xyz>


-- 
Regards

Kieran Bingham