linux-kernel - [tip:efi/core] thunderbolt, efi: Fix Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-79f9cd35b05e3e91ccf9b4038a8b74b9362b5da7@git.kernel.org>
Date:   Tue, 15 Nov 2016 02:50:14 -0800
From:   tip-bot for Lukas Wunner <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     peterz@...radead.org, hpa@...or.com, mingo@...nel.org,
        andreas.noever@...il.com, matt@...eblueprint.co.uk,
        reverser@....as, ard.biesheuvel@...aro.org, tglx@...utronix.de,
        lukas@...ner.de, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, pjones@...hat.com
Subject: [tip:efi/core] thunderbolt, efi: Fix Kconfig dependencies

Commit-ID:  79f9cd35b05e3e91ccf9b4038a8b74b9362b5da7
Gitweb:     http://git.kernel.org/tip/79f9cd35b05e3e91ccf9b4038a8b74b9362b5da7
Author:     Lukas Wunner <lukas@...ner.de>
AuthorDate: Mon, 14 Nov 2016 16:10:33 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 15 Nov 2016 08:33:22 +0100

thunderbolt, efi: Fix Kconfig dependencies

Fix this EFI build failure on certain (rand)configs:

  drivers/firmware/efi/apple-properties.c:149:9: error: implicit declaration of function ???efi_get_device_by_path??? [-Werror=implicit-function-declaration]

which is due to:

  warning: (THUNDERBOLT) selects APPLE_PROPERTIES which has unmet direct dependencies (EFI && EFI_STUB && X86)

Signed-off-by: Lukas Wunner <lukas@...ner.de>
Cc: Andreas Noever <andreas.noever@...il.com>
Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Pedro Vilaça <reverser@....as>
Cc: Peter Jones <pjones@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Pierre Moreau <pierre.morrow@...e.fr> [MacBookPro11,3]
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/20161114151033.GA10141@wunner.de
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/thunderbolt/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
index 0056df7..bb0318c 100644
--- a/drivers/thunderbolt/Kconfig
+++ b/drivers/thunderbolt/Kconfig
@@ -1,7 +1,7 @@
 menuconfig THUNDERBOLT
 	tristate "Thunderbolt support for Apple devices"
 	depends on PCI
-	select APPLE_PROPERTIES
+	select APPLE_PROPERTIES if EFI_STUB
 	select CRC32
 	help
 	  Cactus Ridge Thunderbolt Controller driver