linux-kernel - Re: drivers/block/rbd.c:838: bad if expression ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAOi1vP_R8_1_WT+NSr+nanXf_O-8gvijDgB6f04zH+VYj_rs0w@mail.gmail.com>
Date:   Tue, 15 Nov 2016 14:07:52 +0100
From:   Ilya Dryomov <idryomov@...il.com>
To:     David Binderman <dcb314@...mail.com>
Cc:     "sage@...hat.com" <sage@...hat.com>,
        "elder@...nel.org" <elder@...nel.org>,
        "ceph-devel@...r.kernel.org" <ceph-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: drivers/block/rbd.c:838: bad if expression ?

On Tue, Nov 15, 2016 at 11:38 AM, David Binderman <dcb314@...mail.com> wrote:
> Hello there,
>
> drivers/block/rbd.c:838:34: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
>
> Source code is
>
>    } else if (token > Opt_last_int && token < Opt_last_string) {
>
> but
>
> enum {
>     Opt_queue_depth,
>     Opt_last_int,
>     /* int args above */
>     Opt_last_string,

Hi David,

It's just a placeholder for any string options that might be added in
the future.  See opt_tokens definition in net/ceph/ceph_common.c for an
example (fsid, secret, etc).

Thanks,

                Ilya