linux-kernel - Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161115132627.GR28701@mwanda>
Date:   Tue, 15 Nov 2016 16:26:27 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Rahul Krishnan <mrahul.krishnan@...il.com>
Cc:     rmfrfs@...il.com, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, johan@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single
 statement block

On Tue, Nov 15, 2016 at 06:54:33PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@...il.com>
> ---
>  drivers/staging/greybus/sdio.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index 5649ef1..f60b458 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
>  		state_changed = 1;
>  	}
>  
> -	if (event & GB_SDIO_WP) {
> -		host->read_only = true;
> -	}
> +	if (event & GB_SDIO_WP)
> +	host->read_only = true;

The indenting is messed up.

regards,
dan carpenter