linux-kernel - Re: [PATCH V7 1/3] tracing: add a possibility of exporting function trace to other places instead of ring buffer only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161115102342.7ad27130@gandalf.local.home>
Date:   Tue, 15 Nov 2016 10:23:42 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Chunyan Zhang <zhang.chunyan@...aro.org>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        mingo@...hat.com, Mike Leach <mike.leach@....com>,
        Tor Jeremiassen <tor@...com>, philippe.langlais@...com,
        Nicolas GUION <nicolas.guion@...com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Lyra Zhang <zhang.lyra@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V7 1/3] tracing: add a possibility of exporting function
 trace to other places instead of ring buffer only

On Tue, 15 Nov 2016 16:14:29 +0800
Chunyan Zhang <zhang.chunyan@...aro.org> wrote:

>
> > Then why have a
> >
> >         if (export->write)
> >
> >
> > Is there every going to be a case where export will not have a write
> > function?  
> 
> There shouldn't be.
> 
> I can move this if statement to the register_ftrace_export() to ensure
> users won't wrongly use it, that's saying the write() of trace_export
> has been set before being registered to 'ftrace_exports_list'.
> 

Looks like it's already there:

+int register_ftrace_export(struct trace_export *export)
+{
+	if (WARN_ON_ONCE(!export->write))
+		return -1;


-- Steve