linux-kernel - Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161115155045.GX1041@n2100.armlinux.org.uk>
Date:   Tue, 15 Nov 2016 15:50:45 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of
 <linux/types.h>

On Mon, Nov 07, 2016 at 04:14:48PM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote:
> > Nothing in this header file depends on <linux/types.h>.
> > Rather, <linux/errno.h> should be included for -ENODEV.
> 
> So how do we end up with a definition for u32?
> 
> I think you need both these include files.

I've noticed you haven't responded to the above.

I've discarded the patch you've placed in the patch system in the hope
of a replacement with this comment addressed.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.