linux-kernel - Re: [patch] ARM: socfpga: checking the wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2016 10:01:47 -0600
From:   atull <atull@...nsource.altera.com>
To:     Moritz Fischer <moritz.fischer@...us.com>
CC:     Dan Carpenter <dan.carpenter@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] ARM: socfpga: checking the wrong variable



On Tue, 15 Nov 2016, Moritz Fischer wrote:

> Hi Dan,
> On Tue, Nov 15, 2016 at 1:54 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> > This is a cut and paste bug.  We had intended to check "sysmgr".
> >
> > Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> Acked-by: Moritz Fischer <moritz.fischer@...us.com>

Hi Dan,

Acked-by: Alan Tull <atull@...nsource.altera.com>

Thanks for catching this!

Alan

> 
> >
> > diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> > index 7ab358e..d4eeb74 100644
> > --- a/drivers/fpga/altera-fpga2sdram.c
> > +++ b/drivers/fpga/altera-fpga2sdram.c
> > @@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> >         }
> >
> >         sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
> > -       if (IS_ERR(priv->sdrctl)) {
> > +       if (IS_ERR(sysmgr)) {
> >                 dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
> >                 return PTR_ERR(sysmgr);
> >         }
> 
> Thanks,
> 
> Moritz
>