linux-kernel - Re: [RESEND] fs: ext4: Use current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161115025320.oax4e56om5zcjynt@thunk.org>
Date:   Mon, 14 Nov 2016 21:53:20 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     linux-kernel@...r.kernel.org, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, arnd@...db.de, y2038@...ts.linaro.org
Subject: Re: [RESEND] fs: ext4: Use current_time() for inode timestamps

On Fri, Nov 11, 2016 at 10:32:57AM -0800, Deepa Dinamani wrote:
> CURRENT_TIME_SEC and CURRENT_TIME are not y2038 safe.
> current_time() will be transitioned to be y2038 safe
> along with vfs.
> 
> current_time() returns timestamps according to the
> granularities set in the super_block.
> The granularity check in ext4_current_time() to call
> current_time() or CURRENT_TIME_SEC is not required.
> Use current_time() directly to obtain timestamps
> unconditionally, and remove ext4_current_time().
> 
> Quota files are assumed to be on the same filesystem.
> Hence, use current_time() for these files as well.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied.

					- Ted