linux-kernel - Re: [PATCH 3/3] trace-cmd record: add --cpu-list option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161115163819.5291b752@gandalf.local.home>
Date:   Tue, 15 Nov 2016 16:38:19 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Luiz Capitulino <lcapitulino@...hat.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] trace-cmd record: add --cpu-list option

On Fri, 28 Oct 2016 17:14:56 -0400
Luiz Capitulino <lcapitulino@...hat.com> wrote:


> > 
> > cpu_set(ret_mask, i) sets bits from begin to end in uint64_t cpumask
> > from below.
> > 
> > What happens if this range is greater than 64? We already have boxes
> > that run this with 80 CPUs. Looks to be out of memory range to me.  
> 
> The best solution is probably to detect the number of CPUs at run-time
> and use the CPU_SET() API. The lazy and ugly solution is to just fail.
> 
> Any objections to the CPU_SET() solution?
> 

I thought I replied to this, but I'm guessing the reply is still
pending.

I have no objecting. I'd like to see a patch though.

Thanks,

-- Steve