linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Generic governors support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gUnkuBRbe62aV=ze9A6rAt6QMQ6sQ+7moJox4=G0GKAA@mail.gmail.com>
Date:   Tue, 15 Nov 2016 23:37:11 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Doug Smythies <dsmythies@...us.net>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: Generic governors support

On Tue, Nov 15, 2016 at 6:05 PM, Doug Smythies <dsmythies@...us.net> wrote:
> On 2016.11.13 16:08 Rafael J. Wysocki wrote:
>
>> Rebased on top of my linux-next branch, which in turn is based on 4.9-rc5 now.
>>
>> I'm running this on my IVB laptop w/ the schedutil governor, no problems so
>> far (fingers crossed).
>
> I did the exact same tests as I did with your earlier RFT/RFC version
> of this patch, with the exact same results. I still think something is wrong.

Thanks for the report!

> Reference:
> http://marc.info/?l=linux-kernel&m=147803469901959&w=2

As far as I can test it, both ondemand and schedutil governors work as
expected with it (I haven't tested conservative directly, but it is
similar enough to ondemand).

What happens with the powersave and performance governors is that
->target() is only called once by each of them (during initialization)
and each time the min/max limits change.  That's why you won't see new
requests coming when using any of those two.

Thanks,
Rafael