linux-kernel - Re: [PATCH 2/3] thermal: hisilicon: fix for dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161116053232.GA7240@leoy-linaro>
Date:   Wed, 16 Nov 2016 13:32:32 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Eduardo Valentin <edubezval@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Thierry Reding <treding@...dia.com>,
        Riku Voipio <riku.voipio@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-pm@...r.kernel.org,
        Guodong Xu <guodong.xu@...aro.org>,
        Amit Kucheria <amit.kucheria@...aro.org>
Subject: Re: [PATCH 2/3] thermal: hisilicon: fix for dependency

On Tue, Nov 15, 2016 at 08:24:55PM +0800, Zhang Rui wrote:
> On Sat, 2016-11-12 at 20:05 +0800, Leo Yan wrote:
> > Hi Rui, Eduardo,
> > 
> > On Wed, Aug 31, 2016 at 04:50:16PM +0800, Leo Yan wrote:
> > > 
> > > The thermal driver is standalone driver which is used to enable
> > > thermal sensors, so it can be used with any cooling device and
> > > should not bind with CPU cooling device driver.
> > > 
> > > This original patch is suggested by Amit Kucheria; so it's to
> > > polish the dependency in Kconfig, and remove the dependency with
> > > CPU_THERMAL.
> > Could you help review this patch? Or need me resend this patch? Sorry
> > I have not tracked this patches well before, this is one missed
> > patch for 96board Hikey.
> > 
> as it still applies cleanly, the patch is queued for 4.10.

Thanks a lot.

> thanks,
> rui
> > Thanks,
> > Leo Yan
> > 
> > > 
> > > Signed-off-by: Leo Yan <leo.yan@...aro.org>
> > > ---
> > >  drivers/thermal/Kconfig | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > > index 2d702ca..91ebab3 100644
> > > --- a/drivers/thermal/Kconfig
> > > +++ b/drivers/thermal/Kconfig
> > > @@ -177,8 +177,10 @@ config THERMAL_EMULATION
> > >  
> > >  config HISI_THERMAL
> > >  	tristate "Hisilicon thermal driver"
> > > -	depends on (ARCH_HISI && CPU_THERMAL && OF) ||
> > > COMPILE_TEST
> > > +	depends on ARCH_HISI || COMPILE_TEST
> > >  	depends on HAS_IOMEM
> > > +	depends on OF
> > > +	default y
> > >  	help
> > >  	  Enable this to plug hisilicon's thermal sensor driver
> > > into the Linux
> > >  	  thermal framework. cpufreq is used as the cooling device
> > > to throttle