linux-kernel - linux-next: build warning after merge of the pstore tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 11:27:49 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
        Joel Fernandes <joelaf@...gle.com>
Subject: linux-next: build warning after merge of the pstore tree

Hi Kees,

After merging the pstore tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/rcupdate.h:38:0,
                 from include/linux/idr.h:18,
                 from include/linux/kernfs.h:14,
                 from include/linux/sysfs.h:15,
                 from include/linux/kobject.h:21,
                 from include/linux/device.h:17,
                 from fs/pstore/ram_core.c:17:
fs/pstore/ram_core.c: In function 'buffer_size_add':
include/linux/spinlock.h:246:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
fs/pstore/ram_core.c:78:16: note: 'flags' was declared here
  unsigned long flags;
                ^
In file included from include/linux/rcupdate.h:38:0,
                 from include/linux/idr.h:18,
                 from include/linux/kernfs.h:14,
                 from include/linux/sysfs.h:15,
                 from include/linux/kobject.h:21,
                 from include/linux/device.h:17,
                 from fs/pstore/ram_core.c:17:
fs/pstore/ram_core.c: In function 'buffer_start_add':
include/linux/spinlock.h:246:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
fs/pstore/ram_core.c:56:16: note: 'flags' was declared here
  unsigned long flags;
                ^

Introduced by commit

  95937ddce59a ("pstore: Allow prz to control need for locking")

They appear to be a very noisy false positives. :-(

-- 
Cheers,
Stephen Rothwell