linux-kernel - Re: [PATCH v2] staging: slicoss: fix different address space warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs-H_vu9pNRK+=OgyTmoUq6JK1TOELwAra8YQK5wsqAJsJ1Q@mail.gmail.com>
Date:   Wed, 16 Nov 2016 09:33:26 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Lior Dotan <liodot@...il.com>
Subject: Re: [PATCH v2] staging: slicoss: fix different address space warnings

On Wed, Nov 16, 2016 at 8:05 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Wed, Nov 16, 2016 at 05:07:37AM +0100, Sergio Paracuellos wrote:
>> This patch fix the following sparse warnings in slicoss driver:
>> warning: incorrect type in assignment (different address spaces)
>>
>> Changes in v2:
>> * Remove IOMEM_GET_FIELDADDR macro
>> * Add ioread64 and iowrite64 defines
>>
>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
>> ---
>>  drivers/staging/slicoss/slicoss.c | 111 ++++++++++++++++++++++++++------------
>>  1 file changed, 76 insertions(+), 35 deletions(-)
>>
>> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
>> index d2929b9..d68a463 100644
>> --- a/drivers/staging/slicoss/slicoss.c
>> +++ b/drivers/staging/slicoss/slicoss.c
>> @@ -128,6 +128,35 @@
>>
>>  MODULE_DEVICE_TABLE(pci, slic_pci_tbl);
>>
>> +#ifndef ioread64
>> +#ifdef readq
>> +#define ioread64 readq
>> +#else
>> +#define ioread64 _ioread64
>> +static inline u64 _ioread64(void __iomem *mmio)
>> +{
>> +     u64 low, high;
>> +
>> +     low = ioread32(mmio);
>> +     high = ioread32(mmio + sizeof(u32));
>> +     return low | (high << 32);
>> +}
>> +#endif
>> +#endif
>
> eek, no!  Don't write common kernel functions in a driver just because
> some configuration option was incorrect.  That implies that you really
> can't do that type of read/write for that platform, so maybe you
> shouldn't be doing it!
>
> Split this up into one patch that does the 32bit stuff, then worry
> about the 64bit stuff in a separate patch please.
>
> thanks,
>
> greg k-h

thank you for your clarification, Greg.

I'll send a v3 patchset with the two patches.

Cheers,

Sergio Paracuellos