linux-kernel - Re: [PATCH 1/2] regulator: max77620: add support to configure MPOK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161116121644.4cfuapcqcsqokr32@sirena.org.uk>
Date:   Wed, 16 Nov 2016 12:16:44 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Venkat Reddy Talla <vreddytalla@...dia.com>
Cc:     lee.jones@...aro.org, lgirdwood@...il.com, robh+dt@...nel.org,
        mark.rutland@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldewangan@...dia.com,
        svelpula@...dia.com
Subject: Re: [PATCH 1/2] regulator: max77620: add support to configure MPOK

On Wed, Nov 16, 2016 at 05:22:40PM +0530, Venkat Reddy Talla wrote:

> Adding support to configure regulator POK mapping bit
> to control nRST_IO and GPIO1 POK function.

This leaves me none the wiser as to what this is supposed to do...

> +	if (chip->chip_id == MAX20024) {

Please use switch statements so we can add new cases without rewriting
everything.

> +	ret = of_property_read_u32(np, "maxim,power-ok-control", &pval);
> +	rpdata->power_ok = (!ret) ? pval : -1;
> +

Please write normal logic statements, people need to be able to read the
code and understand what it does.

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)