linux-kernel - Re: [PATCH] checkpatch: don't check c99 types like uint8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1479306861.17487.0.camel@perches.com>
Date:   Wed, 16 Nov 2016 06:34:21 -0800
From:   Joe Perches <joe@...ches.com>
To:     Tomas Winkler <tomas.winkler@...el.com>,
        Andy Whitcroft <apw@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: don't check c99 types like uint8_t under
 tools

On Wed, 2016-11-16 at 10:52 +0200, Tomas Winkler wrote:
> Tools contains user space code so uintX_t types are just fine.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1c4348..42c3221be6eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5548,8 +5548,9 @@ sub process {
>  			      "Using weak declarations can have unintended link defects\n" . $herecurr);
>  		}
>  
> -# check for c99 types like uint8_t used outside of uapi/
> +# check for c99 types like uint8_t used outside of uapi/ and tools/
>  		if ($realfile !~ m@\binclude/uapi/@ &&
> +		    $realfile !~ m@\btools/@ &&
>  		    $line =~ /\b($Declare)\s*$Ident\s*[=;,\[]/) {
>  			my $type = $1;
>  			if ($type =~ /\b($typeC99Typedefs)\b/) {

Makes sense, thanks.

Acked-by: Joe Perches <joe@...ches.com>