linux-kernel - Re: [PATCH 07/34] [media] DaVinci-VPBE: Delete an unnecessary variable initialisation in vpbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161116123534.5fdbda6b@vento.lan>
Date:   Wed, 16 Nov 2016 12:35:34 -0200
From:   Mauro Carvalho Chehab <mchehab@...pensource.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-media@...r.kernel.org, Hans Verkuil <hans.verkuil@...co.com>,
        "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 07/34] [media] DaVinci-VPBE: Delete an unnecessary
 variable initialisation in vpbe_initialize()

Em Wed, 12 Oct 2016 16:42:31 +0200
SF Markus Elfring <elfring@...rs.sourceforge.net> escreveu:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 12 Oct 2016 09:45:39 +0200
> 
> The local variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/media/platform/davinci/vpbe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
> index afa8ff7..9fdd8c0 100644
> --- a/drivers/media/platform/davinci/vpbe.c
> +++ b/drivers/media/platform/davinci/vpbe.c
> @@ -597,7 +597,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
>  	struct osd_state *osd_device;
>  	struct i2c_adapter *i2c_adap;
>  	int num_encoders;
> -	int ret = 0;
> +	int ret;
>  	int err;

Please fold this change to the patch where you'll be addressing the
issues with "err" var, as per my previous email.




Thanks,
Mauro