linux-kernel - Re: [PATCH] block: deal with stale req count of plug list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <320f5131-f61a-9a33-31f4-b510857a4a30@fb.com>
Date:   Wed, 16 Nov 2016 08:10:18 -0700
From:   Jens Axboe <axboe@...com>
To:     Ming Lei <ming.lei@...onical.com>, <linux-kernel@...r.kernel.org>
CC:     <linux-block@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Shaohua Li <shli@...com>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] block: deal with stale req count of plug list

On 11/16/2016 03:07 AM, Ming Lei wrote:
> In both legacy and mq path, req count of plug list is computed
> before allocating request, so the number can be stale when falling
> back to slept allocation, also the new introduced wbt can sleep
> too.
>
> This patch deals with the case by checking if plug list becomes
> empty, and fixes the KASAN report of 'BUG: KASAN: stack-out-of-bounds'
> which is introduced by Shaohua's patches of dispatching big request.

Thanks Ming, added for 4.10.

-- 
Jens Axboe