linux-kernel - Re: [PATCH] scr24x_cs: include linux/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 17:10:34 +0100
From:   Lubomir Rintel <lkundrak@...sk>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scr24x_cs: include linux/io.h

On Wed, 2016-11-16 at 16:23 +0100, Arnd Bergmann wrote:
> The newly added scr24x_cs driver doesn't build in some
> configurations:
> 
> drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready':
> drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of
> function 'ioread8' [-Werror=implicit-function-declaration]
> 
> Adding in explicit include for the right header makes it work.
> 
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/char/pcmcia/scr24x_cs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce1a3be..a1de354a89a7 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -27,6 +27,7 @@
>  #include <linux/cdev.h>
>  #include <linux/slab.h>
>  #include <linux/fs.h>
> +#include <linux/io.h>
>  #include <linux/uaccess.h>
>  
>  #include <pcmcia/cistpl.h>

Acked-by: Lubomir Rintel <lkundrak@...sk>

Thanks