linux-kernel - Re: linux-next: build warning after merge of the phy-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 22:09:36 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     wlf <wulf@...k-chips.com>, Stephen Rothwell <sfr@...b.auug.org.au>
CC:     <linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the phy-next tree

Hi,

On Wednesday 16 November 2016 06:58 PM, wlf wrote:
> Hi Stephen，
> 
> 在 2016年11月16日 11:00, Stephen Rothwell 写道:
>> Hi Kishon,
>>
>> After merging the phy-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
>> drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
>>      if (tmout) {
>>         ^
>>
>> Introduced by commit
>>
>>    0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")

Thank you for reporting this issue.

> The variable "tmout" is initialized in the prior  code "case
> USB_CHG_STATE_WAIT_FOR_DCD",
> and this case will be executed before "if (tmout)", so I think it's a
> mis-warning for some
> special compiler.
> 
> Could you provide me some suggestion about this warning? Should I upload a new
> patch to
> fix this compiler mis-warning or just ignore it ？ :-)

Arnd has already sent a fix it. I've picked that one.

Thanks
Kishon