linux-kernel - Re: [PATCH v2] gpio: Remove GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZQ+XnX7bYDbBpixzDE2Hnv68snp42XO-T=nFN+k6BQzw@mail.gmail.com>
Date:   Wed, 16 Nov 2016 20:49:45 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Keno Fischer <keno@...iacomputing.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        jdike@...toit.com, Richard Weinberger <richard@....at>,
        user-mode-linux-devel@...ts.sourceforge.net,
        Shawn Guo <shawn.guo@...aro.org>,
        Alexandre Courbot <acourbot@...dia.com>
Subject: Re: [PATCH v2] gpio: Remove GPIO_DEVRES option

On Tue, Nov 15, 2016 at 11:39 PM, Keno Fischer <keno@...iacomputing.com> wrote:

> This option was added in 6a89a314ab107a12af08c71420c19a37a30fc2d3 to allow use
> of the devm_gpio_* functions without CONFIG_GPIOLIB. However, only a few months
> later in b69ac52449c658b7ac40034dc3c5f5f4a71a723d, CONFIG_GPIOLIB, was added
> as a dependency, defeating the original purpose of this option. Instead of
> that patch, the original commit could have just been reverted (and in fact
> was partially so in 403c1d0be5ccbd750d25c59d8358843a81e52e3b). Further,
> since this option has a dependency on HAS_IOMEM, even though it does not
> require it, it causes build failures when !HAS_IOMEM (e.g. in a uml build).
> Fix that by completely removing the option, in essence completing the
> reversion of the original commit.

I split up this terse commit message a bit and added your
Signed-off-by and applied for fixes.

Yours,
Linus Walleij