linux-kernel - Re: [PATCH] scsi: dmx3191d: use module_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1611170954190.25297@nippy.intranet>
Date:   Thu, 17 Nov 2016 09:56:45 +1100 (AEDT)
From:   Finn Thain <fthain@...egraphics.com.au>
To:     Geliang Tang <geliangtang@...il.com>
cc:     Michael Schmitz <schmitzmic@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: dmx3191d: use module_pci_driver


On Wed, 16 Nov 2016, Geliang Tang wrote:

> Use module_pci_driver() helper to simplify the code.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>

Acked-by: Finn Thain <fthain@...egraphics.com.au>

> ---
>  drivers/scsi/dmx3191d.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/scsi/dmx3191d.c b/drivers/scsi/dmx3191d.c
> index 3aa4657..6af3394 100644
> --- a/drivers/scsi/dmx3191d.c
> +++ b/drivers/scsi/dmx3191d.c
> @@ -153,18 +153,7 @@ static struct pci_driver dmx3191d_pci_driver = {
>  	.remove		= dmx3191d_remove_one,
>  };
>  
> -static int __init dmx3191d_init(void)
> -{
> -	return pci_register_driver(&dmx3191d_pci_driver);
> -}
> -
> -static void __exit dmx3191d_exit(void)
> -{
> -	pci_unregister_driver(&dmx3191d_pci_driver);
> -}
> -
> -module_init(dmx3191d_init);
> -module_exit(dmx3191d_exit);
> +module_pci_driver(dmx3191d_pci_driver);
>  
>  MODULE_AUTHOR("Massimo Piccioni <dafastidio@...ero.it>");
>  MODULE_DESCRIPTION("Domex DMX3191D SCSI driver");
>