linux-kernel - RE: [PATCH 0/3] PCI: hv: clean-up and 2 fixes to the hot-remove case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 23:19:46 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Dexuan Cui <decui@...rosoft.com>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "Stephen Hemminger" <sthemmin@...rosoft.com>,
        Jake Oshins <jakeo@...rosoft.com>,
        "Hadden Hoppert" <haddenh@...rosoft.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "apw@...onical.com" <apw@...onical.com>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/3] PCI: hv: clean-up and 2 fixes to the hot-remove case



> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@...nel.org]
> Sent: Wednesday, November 16, 2016 2:49 PM
> To: Dexuan Cui <decui@...rosoft.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>; linux-pci@...r.kernel.org;
> devel@...uxdriverproject.org; gregkh@...uxfoundation.org; KY Srinivasan
> <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>; Stephen
> Hemminger <sthemmin@...rosoft.com>; Jake Oshins
> <jakeo@...rosoft.com>; Hadden Hoppert <haddenh@...rosoft.com>;
> Vitaly Kuznetsov <vkuznets@...hat.com>; jasowang@...hat.com;
> apw@...onical.com; olaf@...fle.de; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 0/3] PCI: hv: clean-up and 2 fixes to the hot-remove case
> 
> On Thu, Nov 10, 2016 at 07:16:22AM +0000, Dexuan Cui wrote:
> > PATCH 1 is just a clean-up. There should be no functional change.
> >
> > PATCH 2 and 3 are for device hot-remove case.
> > Currently the driver will stop working or even cause panic, if we do
> > hot add/remove quickly a few times. With the 2 patches, everything works
> > reliably in my tests now.
> >
> > There can be still a potential issue with hot-remove when we unload
> > the driver at the same time. That would require more work of proper
> > synchronization among the 3 paths: the .probe/.remove, the channel
> callback,
> > and the offloaded hv_pci_devices_present()/hv_eject_device_work().
> >
> > But for now, PATCH 2 and 3 do improve the situation a lot.
> >
> > Dexuan Cui (3):
> >   PCI: hv: use the correct buffer size in new_pcichild_device()
> >   PCI: hv: fix hv_pci_remove() for hot-remove
> >   PCI: hv: delete the device earlier from hbus->children for hot-remove
> >
> >  drivers/pci/host/pci-hyperv.c | 67 ++++++++++++++++++++++++++-------
> ----------
> >  1 file changed, 40 insertions(+), 27 deletions(-)
> 
> I applied all three of these to pci/host-hv for v4.10, thanks!
> 
> Jake, I converted your "looks good to me" to Reviewed-by tags.
> 
> K. Y., I added your acks on 2 & 3.  If you acked 1, I missed it.

Thanks Bjorn; I thought I had acked all three, but that is ok.

K. Y