linux-kernel - Re: [PATCH 1/2] net: netcp: replace IS_ERR_OR_NULL by IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 23:27:07 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Julia.Lawall@...6.fr
Cc:     w-kwok2@...com, kernel-janitors@...r.kernel.org,
        m-karicheri2@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, christophe.jaillet@...adoo.fr
Subject: Re: [PATCH 1/2] net: netcp: replace IS_ERR_OR_NULL by IS_ERR

From: Julia Lawall <Julia.Lawall@...6.fr>
Date: Wed, 16 Nov 2016 11:43:33 +0100

> knav_queue_open always returns an ERR_PTR value, never NULL.  This can be
> confirmed by unfolding the function calls and conforms to the function's
> documentation.  Thus, replace IS_ERR_OR_NULL by IS_ERR in error checks.
> 
> The change is made using the following semantic patch:
> (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Applied to net-next, thanks.