linux-kernel - RE: i2c: undefined option I2C_ALGO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14d6032a790e416194159e3ebb43f001@bgmail102.nvidia.com>
Date:   Thu, 17 Nov 2016 08:40:34 +0000
From:   Shardar Mohammed <smohammed@...dia.com>
To:     Thierry Reding <treding@...dia.com>,
        Valentin Rothberg <valentinrothberg@...il.com>
CC:     LKML <linux-kernel@...r.kernel.org>
Subject: RE: i2c: undefined option I2C_ALGO_BUSCLEAR

> On Wed, Nov 16, 2016 at 04:39:57PM +0100, Thierry Reding wrote:
> > On Wed, Nov 16, 2016 at 08:31:35AM +0100, Valentin Rothberg wrote:
> > > Hi Shardar,
> > >
> > > your commit c3ca951fe41a ("i2c: Add Tegra BPMP I2C proxy driver")
> > > popped up in today's linux-next tree, adding Kconfig option
> > > I2C_TEGRA_BPMP, which further selects I2C_ALGO_BUSCLEAR, which is
> > > nowhere defined in Kconfig.
> > >
> > > Is there a patch queued somewhere to add I2C_ALGO_BUSCLEAR to
> Kconfig?
> > >  I could not find anything on the lkml; only some older repositories
> > > on github, where the options is defined in drivers/i2c/busses/Kconfig.
> >
> > This looks to be something that was part of some downstream kernel a
> > long time ago. Given that it doesn't exist upstream and the driver
> > does not use anything related to it, I'll just drop the select. Thanks
> > for pointing this out.
> 
> Actually the I2C_ALGO_BIT seems to be completely unused as well. I'm going
> to drop that, too.
> 
Yes as Thierry mentioned both I2C_ALGO_BUSCLEAR and I2C_ALGO_BIT can be removed as these are obsolete.