linux-kernel - [PATCH v7 0/4] firmware: refactor loading status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1479376851-2307-1-git-send-email-wagi@monom.org>
Date:   Thu, 17 Nov 2016 11:00:47 +0100
From:   Daniel Wagner <wagi@...om.org>
To:     linux-kernel@...r.kernel.org
Cc:     Ming Lei <ming.lei@...onical.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Takashi Iwai <tiwai@...e.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Yves-Alexis Perez <corsac@...sac.net>,
        Daniel Wagner <daniel.wagner@...-carit.de>
Subject: [PATCH v7 0/4] firmware: refactor loading status

From: Daniel Wagner <daniel.wagner@...-carit.de>

Hi,

after the lengthy discussion online and in person I decided to remove
all things which might change behavoir. So this is refactore clean up
version. I think it worth to consider it because this version gets rid
of the fw_lock dependency for protecting the loading status.

It is based on Yves-Alexis' patch "firmware: fix usermode helper
fallback loading". According this patch I fixed the type cast
error in __fw_state_wait_common(). This function returns a long
now.

The last patch could be merged into second last. I decided to
split it to make the review easier.

cheers,
daniel

changes since v6:
  - removed all controversial patches which change behavoir
  - fixed casting error in return type in __fw_state_wait_common()
  - rebased in on v4.9-rc5 + Yves-Alexis' patch.

changes since v5:
  - add enum name (enum fw_status)
  - renamed function prefix and structure fw_umh to fw_state (avoid to
    clash with enum fw_status)
  - add back patch 1 from v3
  - move unused functions for direct firmeware loading into UMH section

changes since v4:
  - replaced "firmware: Move umh locking code into fw_load_from_user_helper()"
    with "firmware: document user mode helper lock usage"
  - changed prefix fw_status_ to fw_umh_
  - fixed a couple of bux pointed out by Ming
  - changed type of fw_umh::status to u8 and updated commit message to
    point out that all states are exclusive

changes since v3:
  - added 'firmware: Move umh locking code into
    fw_load_from_user_helper()'
  - dropped loading_tiemout and firmware_loading_time() for
    !CONFG_FW_LOADER_USER_HELPER
  - rebased on Luis patches

changes since v2:
  - more splitting out
    - first patch factors out all the bit ops into fw_status
    - second patch gets rid of the bit ops
    - third get rid of fw_lock by using swait

changes since v1:
  - moved swait change into its own patch
  - added ifdef section for FW_LOADER_USER_HELPER_FALLBACK
  - updated commit message highlighting the mutex usage drop a bit



Daniel Wagner (4):
  firmware: refactor loading status
  firmware: drop bit ops in favor of simple state machine
  firmware: do not use fw_lock for fw_state protection
  firmware: move fw_state_is_done() into UHM section

 drivers/base/firmware_class.c | 156 ++++++++++++++++++++++++++----------------
 1 file changed, 96 insertions(+), 60 deletions(-)

-- 
2.7.4