linux-kernel - [PATCH 1/1] ARM: socfpga: checking the wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161117015440.3113-2-atull@opensource.altera.com>
Date:   Wed, 16 Nov 2016 19:54:40 -0600
From:   Alan Tull <atull@...nsource.altera.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>,
        Moritz Fischer <moritz.fischer@...us.com>,
        Dinh Nguyen <dinguyen@...nsource.altera.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        <kernel-janitors@...r.kernel.org>, <delicious.quinoa@...il.com>
Subject: [PATCH 1/1] ARM: socfpga: checking the wrong variable

From: Dan Carpenter <dan.carpenter@...cle.com>

This is a cut and paste bug.  We had intended to check "sysmgr".

Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Acked-by: Moritz Fischer <moritz.fischer@...us.com>
Acked-by: Alan Tull <atull@...nsource.altera.com>
---
 drivers/fpga/altera-fpga2sdram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
index 7ab358e..d4eeb74 100644
--- a/drivers/fpga/altera-fpga2sdram.c
+++ b/drivers/fpga/altera-fpga2sdram.c
@@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
 	}
 
 	sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
-	if (IS_ERR(priv->sdrctl)) {
+	if (IS_ERR(sysmgr)) {
 		dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
 		return PTR_ERR(sysmgr);
 	}
-- 
2.7.4