linux-kernel - Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161117120257.GB22450@kroah.com>
Date:   Thu, 17 Nov 2016 13:02:57 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sven Eckelmann <sven@...fation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Linus Lüssing <linus.luessing@...3.blue>,
        Simon Wunderlich <sw@...onwunderlich.de>
Subject: Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface

On Thu, Nov 17, 2016 at 11:51:24AM +0100, Sven Eckelmann wrote:
> On Donnerstag, 17. November 2016 11:32:51 CET Greg Kroah-Hartman wrote:
> > 4.8-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Linus Lüssing <linus.luessing@...3.blue>
> > 
> > commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream.
> > 
> > As long as there is still a reference for a hard interface held, there might
> > still be a forwarding packet relying on its attributes.
> > 
> > Therefore avoid setting hard_iface->soft_iface to NULL when disabling a hard
> > interface.
> > 
> > This fixes the following, potential splat:
> > 
> [...]
> 
> Thanks for your backporting efforts. There is already a revert for this patch
> queued up in batadv/net [1] (targets net.git). So maybe you want to drop this
> patch from your stable queue.
> 
> We also got test results from Linus which showed that this problem didn't
> happen anymore with recent kernel versions (without his patch). These results
> made him also Ack the revert.
> 
> Sorry about this confusing situation.

Not a problem, I've dropped this one from the patch queue now, thanks
for letting me know.

greg k-h