lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Nov 2016 15:31:22 +0100 From: Johan Hovold <johan@...nel.org> To: Thierry Reding <thierry.reding@...il.com> Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org> Subject: Re: [PATCH] pwm: fix device reference leak On Tue, Nov 01, 2016 at 11:46:39AM +0100, Johan Hovold wrote: > Make sure to drop the reference to the parent device taken by > class_find_device() after "unexporting" any children when deregistering > a pwm chip. > > Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal") > Signed-off-by: Johan Hovold <johan@...nel.org> > --- > drivers/pwm/sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c > index 0296d8178ae2..a813239300c3 100644 > --- a/drivers/pwm/sysfs.c > +++ b/drivers/pwm/sysfs.c > @@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip) > if (test_bit(PWMF_EXPORTED, &pwm->flags)) > pwm_unexport_child(parent, pwm); > } > + > + put_device(parent); > } > > static int __init pwm_sysfs_init(void) Thought I'd send a gentle reminder about this one. Is it still in your queue, Thierry? Thanks, Johan
Powered by blists - more mailing lists