linux-kernel - Re: [tpmdd-devel] [PATCH] tpm: drop chip->is_open and chip->duration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161117173641.uppc5vetyfuab7ts@intel.com>
Date:   Thu, 17 Nov 2016 09:36:41 -0800
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Nayna <nayna@...ux.vnet.ibm.com>
Cc:     tpmdd-devel@...ts.sourceforge.net,
        Christophe Ricard <christophe.ricard@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        linux-security-module@...r.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: drop chip->is_open and
 chip->duration_adjusted

On Thu, Nov 17, 2016 at 04:10:29PM +0530, Nayna wrote:
> On 11/15/2016 05:14 AM, Jarkko Sakkinen wrote:
> > -	if (chip->flags & (TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_VIRTUAL))
> > -		return 0;
> > +	if (test_bit(TPM_CHIP_FLAG_TPM2, &chip->flags) ||
> > +	    test_bit(TPM_CHIP_FLAG_VIRTUAL, &chip->flags))
> > +		return;
> 
> guess should be "return 0;"

Ouch. Good catch. Thank you.

/Jarkko