linux-kernel - Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161117082737.7f6ff329@t450s.home>
Date:   Thu, 17 Nov 2016 08:27:37 -0700
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Jike Song <jike.song@...el.com>
Cc:     Kirti Wankhede <kwankhede@...dia.com>, pbonzini@...hat.com,
        kraxel@...hat.com, cjia@...dia.com, qemu-devel@...gnu.org,
        kvm@...r.kernel.org, kevin.tian@...el.com,
        bjsdjshi@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops
 structure of mdev

On Thu, 17 Nov 2016 20:35:38 +0800
Jike Song <jike.song@...el.com> wrote:

> On 11/17/2016 04:46 AM, Kirti Wankhede wrote:
> > Add a notifier calback to parent's ops structure of mdev device so that per
> > device notifer for vfio module is registered through vfio_mdev module.
> > 
> > Signed-off-by: Kirti Wankhede <kwankhede@...dia.com>
> > Signed-off-by: Neo Jia <cjia@...dia.com>
> > Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637
> > ---
> >  drivers/vfio/mdev/vfio_mdev.c | 34 +++++++++++++++++++++++++++++++++-
> >  include/linux/mdev.h          |  9 +++++++++
> >  2 files changed, 42 insertions(+), 1 deletion(-)
> > 
> 
> Hi Alex, Kirti,
> 
> Since everyone agreed we should let the vendor driver call vfio_register_notifier
> directly, can you drop this patch from merging? So that I don't need to send a
> reverse patch.

This seems like a reasonable request to me, this patch drops cleanly
from the series.  Any objection Kirti?  It seems like it removes a
little bit of pre-release churn from the API.  Thanks,

Alex