linux-kernel - Re: [PATCH 1/3] net: stmmac: replace all pr_xxx by their netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2016 13:30:58 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     clabbe.montjoie@...il.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] net: stmmac: replace all pr_xxx by their
 netdev_xxx counterpart

From: Corentin Labbe <clabbe.montjoie@...il.com>
Date: Wed, 16 Nov 2016 20:09:39 +0100

> From: LABBE Corentin <clabbe.montjoie@...il.com>
> 
> The stmmac driver use lots of pr_xxx functions to print information.
> This is bad since we cannot know which device logs the information.
> (moreover if two stmmac device are present)
> 
> Furthermore, it seems that it assumes wrongly that all logs will always
> be subsequent by using a dev_xxx then some indented pr_xxx like this:
> kernel: sun7i-dwmac 1c50000.ethernet: no reset control found
> kernel:  Ring mode enabled
> kernel:  No HW DMA feature register supported
> kernel:  Normal descriptors
> kernel:  TX Checksum insertion supported
> 
> So this patch replace all pr_xxx by their netdev_xxx counterpart.
> Excepts for some printing where netdev "cause" unpretty output like:
> sun7i-dwmac 1c50000.ethernet (unnamed net_device) (uninitialized): no reset control found
> In those case, I keep dev_xxx.
> 
> In the same time I remove some "stmmac:" print since
> this will be a duplicate with that dev_xxx displays.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Applied to net-next.