linux-kernel - Re: [RFC][PATCH] cpufreq: intel_pstate: Support of energy performance hint using HWP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1479411092.6544.129.camel@linux.intel.com>
Date:   Thu, 17 Nov 2016 11:31:32 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     rjw@...ysocki.net, morten.rasmussen@....com, Juri.Lelli@....com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] cpufreq: intel_pstate: Support of energy
 performance hint using HWP

Hi Viresh,
On Thu, 2016-11-17 at 12:19 +0530, Viresh Kumar wrote:
> Hi Srinivas,
> 
> I don't think other platforms need it for now and so it is fine to
> add these to the driver itself.
Good to know. In this case I will proceed with change only local to
intel_pstate.

> 
> On 15-11-16, 14:59, Srinivas Pandruvada wrote:
> > 
> > +static ssize_t show_energy_performance_available_preferences(
> 
> Maybe a personal preference, but I would have broken the line after
> ssize_t instead of where you have done it.
I can change that.

> 
> > 
> > +				struct cpufreq_policy *policy,
> > char *buf)
> > +{
> > +static struct freq_attr *hwp_cpufreq_attrs[] = {
> > +	&energy_performance_preference,
> > +	&energy_performance_available_preferences,
> > +	NULL,
> > +};
> 
> What about adding these to intel_pstate_attr_group instead ?
Sure.

Thanks,
Srinivas