linux-kernel - Re: [patch 1/2] mm, zone: track number of pages in free area by migratetype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1611171405210.99747@chino.kir.corp.google.com>
Date:   Thu, 17 Nov 2016 14:11:27 -0800 (PST)
From:   David Rientjes <rientjes@...gle.com>
To:     Vlastimil Babka <vbabka@...e.cz>
cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Michal Hocko <mhocko@...e.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [patch 1/2] mm, zone: track number of pages in free area by
 migratetype

On Thu, 17 Nov 2016, Vlastimil Babka wrote:

> > The total number of free pages is still tracked, however, to not make
> > zone_watermark_ok() more expensive.  Reading /proc/pagetypeinfo, however,
> > is faster.
> 
> Yeah I've already seen a case with /proc/pagetypeinfo causing soft
> lockups due to high number of iterations...
> 

Thanks for taking a look at the patchset!

Wow, I haven't seen /proc/pagetypeinfo soft lockups yet, I thought this 
was a relatively minor point :)  But it looks like we need some 
improvement in this behavior independent of memory compaction anyway.

> > This patch introduces no functional change and increases the amount of
> > per-zone metadata at worst by 48 bytes per memory zone (when CONFIG_CMA
> > and CONFIG_MEMORY_ISOLATION are enabled).
> 
> Isn't it 48 bytes per zone and order?
> 

Yes, sorry, I'll fix that in v2.  I think less than half a kilobyte for 
each memory zone is satisfactory for extra tracking, compaction 
improvements, and optimized /proc/pagetypeinfo, though.

> > Signed-off-by: David Rientjes <rientjes@...gle.com>
> 
> I'd be for this if there are no performance regressions. It affects hot
> paths and increases cache footprint. I think at least some allocator
> intensive microbenchmark should be used.
> 

I can easily implement a test to stress movable page allocations from 
fallback MIGRATE_UNMOVABLE pageblocks and freeing back to the same 
pageblocks.  I assume we're not interested in memory offline benchmarks.

What do you think about the logic presented in patch 2/2?  Are you 
comfortable with a hard-coded ratio such as 1/64th of free memory or would 
you prefer to look at the zone's watermark with the number of free pages 
from MIGRATE_MOVABLE pageblocks rather than NR_FREE_PAGES?  I was split 
between the two options.